Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add more kcl modules about kcl examples, kcl charts and container modules. #25

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Oct 30, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

feat: add more kcl modules about kcl examples, kcl charts and container modules.

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@Peefy Peefy changed the title [WIP] feat: add more kcl modules about kcl examples, kcl charts and container modules. feat: add more kcl modules about kcl examples, kcl charts and container modules. Oct 30, 2023
@Peefy Peefy force-pushed the add-more-kcl-modules branch from 2c4a930 to 6a7018b Compare October 30, 2023 02:09
@Peefy Peefy changed the title feat: add more kcl modules about kcl examples, kcl charts and container modules. [WIP] feat: add more kcl modules about kcl examples, kcl charts and container modules. Oct 30, 2023
…er modules.

Signed-off-by: peefy <xpf6677@163.com>
@Peefy Peefy force-pushed the add-more-kcl-modules branch from 0f4a6f4 to 10bd085 Compare October 30, 2023 07:27
@Peefy Peefy changed the title [WIP] feat: add more kcl modules about kcl examples, kcl charts and container modules. feat: add more kcl modules about kcl examples, kcl charts and container modules. Oct 30, 2023
Copy link
Collaborator

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zong-zhe zong-zhe merged commit 60dced8 into main Oct 30, 2023
@Peefy Peefy deleted the add-more-kcl-modules branch October 30, 2023 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants