Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add alias name for dependency #229

Merged
merged 3 commits into from
Dec 19, 2023
Merged

feat: add alias name for dependency #229

merged 3 commits into from
Dec 19, 2023

Conversation

zong-zhe
Copy link
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

Fixed kcl-lang/kcl#366

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

Signed-off-by: zongz <zongzhe1024@163.com>
@zong-zhe zong-zhe added the enhancement New feature or request label Dec 19, 2023
@zong-zhe zong-zhe requested review from i-zhen and Peefy December 19, 2023 09:29
@zong-zhe zong-zhe self-assigned this Dec 19, 2023
@coveralls
Copy link

coveralls commented Dec 19, 2023

Pull Request Test Coverage Report for Build 7261321764

  • 10 of 38 (26.32%) changed or added relevant lines in 4 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 38.705%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cmd/cmd_metadata.go 0 1 0.0%
pkg/package/package.go 0 3 0.0%
pkg/client/client.go 10 15 66.67%
pkg/package/modfile.go 0 19 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/client/client.go 1 52.61%
Totals Coverage Status
Change from base Build 7204283694: -0.1%
Covered Lines: 1429
Relevant Lines: 3692

💛 - Coveralls

Signed-off-by: zongz <zongzhe1024@163.com>
@zong-zhe zong-zhe marked this pull request as draft December 19, 2023 11:01
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: zongz <zongzhe1024@163.com>
@zong-zhe zong-zhe marked this pull request as ready for review December 19, 2023 11:43
@zong-zhe zong-zhe merged commit 96db150 into kcl-lang:main Dec 19, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
No open projects
Status: v0.7.0 Release Done
3 participants