Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue #90 on config_expr type infer. #91

Merged
merged 1 commit into from
Jun 20, 2022

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Jun 14, 2022

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

fix #90

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

The test case in kclvm/sema/src/resolver/test_fail_data/config_expr.k is used to test config_expr type check error.

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@Peefy Peefy changed the title fix: issue #88 on config_expr type infer. fix: issue #90 on config_expr type infer. Jun 14, 2022
@Peefy Peefy self-assigned this Jun 14, 2022
@Peefy Peefy added bug Something isn't working resolver labels Jun 14, 2022
@Peefy Peefy added this to the v0.4.3 Release milestone Jun 14, 2022
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 2495712525

  • 13 of 13 (100.0%) changed or added relevant lines in 2 files are covered.
  • 393 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.4%) to 36.978%

Files with Coverage Reduction New Missed Lines %
kclvm/sema/src/resolver/scope.rs 4 39.11%
kclvm/3rdparty/rustc_span/src/lib.rs 389 31.15%
Totals Coverage Status
Change from base Build 2473460180: 0.4%
Covered Lines: 13468
Relevant Lines: 36422

💛 - Coveralls

Copy link
Contributor

@chai2010 chai2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy requested review from chai2010 and zong-zhe June 20, 2022 06:21
Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 1b71e25 into kcl-lang:main Jun 20, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jun 20, 2022
@Peefy Peefy deleted the peefy-fix-issue-88 branch July 13, 2022 07:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working resolver
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Config expression is deduced as any type in resolver.
4 participants