Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add plugins submodule. #9

Merged
merged 3 commits into from
May 13, 2022
Merged

feat: add plugins submodule. #9

merged 3 commits into from
May 13, 2022

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented May 13, 2022

Purpose:

  1. add kcl plugin submodule

@Peefy Peefy requested review from zong-zhe and chai2010 May 13, 2022 11:33
@chai2010
Copy link
Contributor

LGTM

zong-zhe
zong-zhe approved these changes May 13, 2022
View reviewed changes
Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zong-zhe zong-zhe merged commit 6479545 into main May 13, 2022
@Peefy Peefy deleted the dev/peefy/feat_add_plugin_submodule branch May 22, 2022 07:49
NeverRaR pushed a commit to NeverRaR/KCLVM that referenced this pull request Nov 14, 2023
@He1pa
Merge pull request kcl-lang#9 from NeverRaR/migrate_complete_dot
04d2a1a 
feat: support builtin symbol
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chai2010 chai2010 chai2010 approved these changes

@zong-zhe zong-zhe zong-zhe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Peefy @chai2010 @zong-zhe