Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(LSP): Document symbol(Outline) #494

Merged
merged 2 commits into from
Apr 10, 2023
Merged

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Apr 7, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

2. What is the scope of this PR (e.g. component or file name):

LSP

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

Feat(LSP): Document Symbol Provider. Select variable and schema definition and shown with document symbol(Outline in vscode)

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@coveralls
Copy link
Collaborator

coveralls commented Apr 7, 2023

Pull Request Test Coverage Report for Build 4655963047

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.988%

Totals Coverage Status
Change from base Build 4655096333: 0.0%
Covered Lines: 2300
Relevant Lines: 2614

💛 - Coveralls

@Peefy Peefy added the lsp label Apr 7, 2023
@Peefy Peefy added this to the v0.4.6 Release milestone Apr 7, 2023
kclvm/tools/src/LSP/src/document_symbol.rs Outdated Show resolved Hide resolved
kclvm/tools/src/LSP/src/document_symbol.rs Outdated Show resolved Hide resolved
kclvm/tools/src/LSP/src/document_symbol.rs Outdated Show resolved Hide resolved
kclvm/tools/src/LSP/src/document_symbol.rs Outdated Show resolved Hide resolved
kclvm/tools/src/LSP/src/request.rs Outdated Show resolved Hide resolved
@He1pa He1pa force-pushed the document_symbol branch 4 times, most recently from e40afb4 to 30ffc18 Compare April 10, 2023 07:01
…ition and shown with document symbol(Outline in vscode)
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 3787522 into kcl-lang:main Apr 10, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants