Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: Fix CI failure cause by inconsistent order of walk files #493

Merged
merged 1 commit into from
Apr 7, 2023

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Apr 7, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

Fix CI failure cause by inconsistent order of walk files.

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@coveralls
Copy link
Collaborator

coveralls commented Apr 7, 2023

Pull Request Test Coverage Report for Build 4636872682

  • 8 of 8 (100.0%) changed or added relevant lines in 3 files are covered.
  • 31 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-21.3%) to 66.66%

Files with Coverage Reduction New Missed Lines %
compiler_base/session/src/lib.rs 31 45.16%
Totals Coverage Status
Change from base Build 4635640020: -21.3%
Covered Lines: 27432
Relevant Lines: 41152

💛 - Coveralls

@Peefy Peefy added ci bug Something isn't working labels Apr 7, 2023
@Peefy Peefy added this to the v0.4.6 Release milestone Apr 7, 2023
@He1pa He1pa force-pushed the bugfix_completion_ci_test_failed branch from 414a454 to 140a1b2 Compare April 7, 2023 05:51
@He1pa He1pa force-pushed the bugfix_completion_ci_test_failed branch from 140a1b2 to 2c07d0d Compare April 7, 2023 08:54
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 0aa10b7 into kcl-lang:main Apr 7, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working ci
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants