Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(LSP): Load pkg files in LSP #483

Merged
merged 1 commit into from
Apr 6, 2023
Merged

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Apr 4, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

LSP

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

If the input file of lsp is not in a stack environment, load all kcl files in the dir where the file is located as input

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@coveralls
Copy link
Collaborator

coveralls commented Apr 4, 2023

Pull Request Test Coverage Report for Build 4624927412

  • 25 of 31 (80.65%) changed or added relevant lines in 2 files are covered.
  • 31 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-22.6%) to 65.385%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/driver/src/lib.rs 24 30 80.0%
Files with Coverage Reduction New Missed Lines %
compiler_base/session/src/lib.rs 31 45.16%
Totals Coverage Status
Change from base Build 4596082952: -22.6%
Covered Lines: 24564
Relevant Lines: 37568

💛 - Coveralls

@Peefy Peefy added the lsp label Apr 4, 2023
@Peefy Peefy added this to the v0.4.6 Release milestone Apr 4, 2023
kclvm/driver/src/lib.rs Outdated Show resolved Hide resolved
kclvm/driver/src/lib.rs Show resolved Hide resolved
kclvm/driver/src/lib.rs Outdated Show resolved Hide resolved
kclvm/driver/src/lib.rs Outdated Show resolved Hide resolved
… stack environment, load all kcl files in the dir where the file is located as input
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 84186e9 into kcl-lang:main Apr 6, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants