Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: impl schema query API. #471

Merged
merged 1 commit into from
Mar 27, 2023
Merged

feat: impl schema query API. #471

merged 1 commit into from
Mar 27, 2023

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Mar 27, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

feat: #418

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
  • kclvm/capi/src/service/service.rs

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@Peefy Peefy added the api Issues or PRs related to kcl rust native APIs and multi-lang APIs label Mar 27, 2023
@Peefy Peefy added this to the v0.4.6 Release milestone Mar 27, 2023
@Peefy Peefy self-assigned this Mar 27, 2023
@coveralls
Copy link
Collaborator

coveralls commented Mar 27, 2023

Pull Request Test Coverage Report for Build 4532267499

  • 15 of 175 (8.57%) changed or added relevant lines in 8 files are covered.
  • 36 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-25.5%) to 63.802%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/capi/src/api_test.rs 6 8 75.0%
kclvm/capi/src/service/api.rs 3 16 18.75%
kclvm/capi/src/service/service.rs 2 25 8.0%
kclvm/query/src/query.rs 0 48 0.0%
kclvm/capi/src/service/ty.rs 0 74 0.0%
Files with Coverage Reduction New Missed Lines %
compiler_base/session/src/lib.rs 36 37.1%
Totals Coverage Status
Change from base Build 4529330673: -25.5%
Covered Lines: 22670
Relevant Lines: 35532

💛 - Coveralls

NeverRaR
NeverRaR previously approved these changes Mar 27, 2023
Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 7834f04 into kcl-lang:main Mar 27, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2023
@Peefy Peefy deleted the schema-query-api branch March 28, 2023 03:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api Issues or PRs related to kcl rust native APIs and multi-lang APIs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] KCL needs to provide API to list variables and attributes (including their name and type)
4 participants