Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: impl all parse error recovery with panic mode and add more unit test cases #460

Merged
merged 1 commit into from
Mar 22, 2023

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Mar 21, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

re #420

feat: parse error recovery with panic mode and add more unit test cases with the parse error recovery strategy in #420.

2. What is the scope of this PR (e.g. component or file name):

  • kclvm_parser
  • kclvm_sema

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
  • unit tests at kclvm/parser/src/tests/error_recovery.rs
  • all grammar and konfig integration tests

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@Peefy Peefy added parser Issues or PRs related to kcl parser error-handling Issues or PRs related to kcl error handling resolver labels Mar 21, 2023
@Peefy Peefy added this to the v0.4.6 Release milestone Mar 21, 2023
@Peefy Peefy self-assigned this Mar 21, 2023
@coveralls
Copy link
Collaborator

coveralls commented Mar 21, 2023

Pull Request Test Coverage Report for Build 4478550833

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.313%

Totals Coverage Status
Change from base Build 4464079596: 0.0%
Covered Lines: 2106
Relevant Lines: 2358

💛 - Coveralls

@Peefy Peefy force-pushed the parse-error-recovery-with-panic-mode branch from f8e475d to bbfae4f Compare March 21, 2023 11:35
Copy link
Contributor

@He1pa He1pa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Peefy Peefy changed the title [WIP] feat: impl all parse error recovery with panic mode and add more unit test cases feat: impl all parse error recovery with panic mode and add more unit test cases Mar 22, 2023
@Peefy Peefy merged commit ea229de into kcl-lang:main Mar 22, 2023
@Peefy Peefy deleted the parse-error-recovery-with-panic-mode branch March 22, 2023 03:31
@github-actions github-actions bot locked and limited conversation to collaborators Mar 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
error-handling Issues or PRs related to kcl error handling parser Issues or PRs related to kcl parser resolver
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants