Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: using parse sess instead of compiler base session to return errors for IDE #457

Merged
merged 2 commits into from
Mar 17, 2023

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Mar 17, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

re #420. refactor: using parse sess instead of compiler base session to return errors for IDE

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
  • Unit test: kclvm/parser/src/tests/error_recovery.rs
  • All integration grammar and konfig tests.

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@Peefy Peefy added parser Issues or PRs related to kcl parser error-handling Issues or PRs related to kcl error handling labels Mar 17, 2023
@Peefy Peefy added this to the v0.4.6 Release milestone Mar 17, 2023
@Peefy Peefy requested review from He1pa and zong-zhe March 17, 2023 02:21
@Peefy Peefy self-assigned this Mar 17, 2023
@coveralls
Copy link
Collaborator

coveralls commented Mar 17, 2023

Pull Request Test Coverage Report for Build 4443528722

  • 73 of 88 (82.95%) changed or added relevant lines in 16 files are covered.
  • 31 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-28.6%) to 60.697%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/src/lib.rs 0 1 0.0%
kclvm/cmd/src/run.rs 0 5 0.0%
kclvm/error/src/error.rs 5 14 35.71%
Files with Coverage Reduction New Missed Lines %
compiler_base/session/src/lib.rs 31 45.16%
Totals Coverage Status
Change from base Build 4436717496: -28.6%
Covered Lines: 18569
Relevant Lines: 30593

💛 - Coveralls

Copy link
Contributor

@He1pa He1pa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Peefy Peefy merged commit 1766e58 into kcl-lang:main Mar 17, 2023
@Peefy Peefy deleted the refactor-parse-sess branch March 17, 2023 03:11
@github-actions github-actions bot locked and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
error-handling Issues or PRs related to kcl error handling parser Issues or PRs related to kcl parser
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants