Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: lexer error recovery including string, number literals, and indents. #453

Merged
merged 3 commits into from
Mar 15, 2023

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Mar 15, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

feat #420. Impl the lexer error recovery including string, number literals, and indents.

2. What is the scope of this PR (e.g. component or file name):

  • kclvm_parser crate
  • kclvm_error crate

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
  • Unit test: kclvm/parser/src/tests/error_recovery.rs
  • All grammar and Konfig Interagration test

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@Peefy Peefy added lexer Issues or PRs related to kcl lexer parser Issues or PRs related to kcl parser labels Mar 15, 2023
@Peefy Peefy added this to the v0.4.6 Release milestone Mar 15, 2023
@Peefy Peefy self-assigned this Mar 15, 2023
@coveralls
Copy link
Collaborator

coveralls commented Mar 15, 2023

Pull Request Test Coverage Report for Build 4422152166

  • 104 of 140 (74.29%) changed or added relevant lines in 12 files are covered.
  • 31 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-23.5%) to 65.789%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/parser/src/lexer/tests.rs 3 4 75.0%
kclvm/parser/src/lib.rs 11 12 91.67%
kclvm/parser/src/parser/expr.rs 6 7 85.71%
kclvm/src/lib.rs 0 1 0.0%
kclvm/lexer/src/lib.rs 5 8 62.5%
kclvm/parser/src/lexer/string.rs 0 3 0.0%
kclvm/parser/src/lexer/mod.rs 59 70 84.29%
kclvm/parser/src/lexer/indent.rs 10 25 40.0%
Files with Coverage Reduction New Missed Lines %
compiler_base/session/src/lib.rs 31 45.16%
Totals Coverage Status
Change from base Build 4417313179: -23.5%
Covered Lines: 25965
Relevant Lines: 39467

💛 - Coveralls

Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit a330447 into kcl-lang:main Mar 15, 2023
@Peefy Peefy deleted the lexer-error-recovery branch March 15, 2023 07:48
@github-actions github-actions bot locked and limited conversation to collaborators Mar 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lexer Issues or PRs related to kcl lexer parser Issues or PRs related to kcl parser
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants