Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add community link in readme. #238

Merged
merged 1 commit into from
Oct 12, 2022
Merged

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Oct 12, 2022

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

feat: add community link in readme.

2. What is the scope of this PR (e.g. component or file name):

  • README-zh.md
  • README.md

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@Peefy Peefy added the documentation Improvements or additions to documentation label Oct 12, 2022
@Peefy Peefy added this to the v0.4.4 Release milestone Oct 12, 2022
@Peefy Peefy requested review from He1pa and zong-zhe October 12, 2022 04:15
@Peefy Peefy self-assigned this Oct 12, 2022
Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@He1pa He1pa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 3231978903

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 141 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.6%) to 59.195%

Files with Coverage Reduction New Missed Lines %
kclvm/runner/src/assembler.rs 1 97.86%
kclvm/sema/src/resolver/node.rs 9 75.23%
kclvm/sema/src/ty/mod.rs 35 66.02%
kclvm/sema/src/resolver/config.rs 42 79.61%
kclvm/parser/src/lib.rs 54 83.44%
Totals Coverage Status
Change from base Build 3226038526: -0.6%
Covered Lines: 20961
Relevant Lines: 35410

💛 - Coveralls

@Peefy Peefy merged commit 5f5dbfb into kcl-lang:main Oct 12, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 12, 2022
@Peefy Peefy deleted the add-community-link branch November 4, 2022 12:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants