Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(kclvm-tools): add json/yaml file loader for KCL-Vet. #219

Merged
merged 6 commits into from
Sep 27, 2022
Merged

Feat(kclvm-tools): add json/yaml file loader for KCL-Vet. #219

merged 6 commits into from
Sep 27, 2022

Conversation

zong-zhe
Copy link
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

issue #67.

2. What is the scope of this PR (e.g. component or file name):

kclvm-tools/util

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

add json/yaml file loader for KCL-Vet in kclvm/tools/util.

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@zong-zhe zong-zhe added this to the v0.4.4 Release milestone Sep 26, 2022
@zong-zhe zong-zhe self-assigned this Sep 26, 2022
@coveralls
Copy link
Collaborator

coveralls commented Sep 26, 2022

Pull Request Test Coverage Report for Build 3127704207

  • 171 of 176 (97.16%) changed or added relevant lines in 2 files are covered.
  • 168 unchanged lines in 7 files lost coverage.
  • Overall coverage decreased (-1.4%) to 59.495%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/tools/src/util/tests.rs 140 145 96.55%
Files with Coverage Reduction New Missed Lines %
kclvm/ast/src/token_stream.rs 6 78.57%
kclvm/error/src/error.rs 6 12.5%
kclvm/capi/src/service/service.rs 9 78.67%
kclvm/src/main.rs 19 1.12%
kclvm/error/src/lib.rs 28 43.02%
kclvm/runner/src/lib.rs 45 56.73%
kclvm/runtime/src/context/mod.rs 55 13.4%
Totals Coverage Status
Change from base Build 3112516770: -1.4%
Covered Lines: 21379
Relevant Lines: 35934

💛 - Coveralls

ldxdl
ldxdl previously approved these changes Sep 26, 2022
Copy link
Contributor

@ldxdl ldxdl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Peefy
Peefy previously approved these changes Sep 26, 2022
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy
Copy link
Contributor

Peefy commented Sep 26, 2022

Need more test cases about invalid file path and Json/YAML data.

@zong-zhe zong-zhe dismissed stale reviews from Peefy and ldxdl via c595d04 September 26, 2022 11:31
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@He1pa He1pa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 8ec986b into kcl-lang:main Sep 27, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Sep 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants