refactor: adjusted some macros in kclvm-parser and add some methods in kclvm-ast #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Peefy
reviewed
May 19, 2022
zong-zhe
force-pushed
the
dev/zong-zhe/add_utils_to_ast
branch
from
a79c63a
to
ad3f991
Compare
chai2010
reviewed
May 19, 2022
…n kclvm-ast. Note: 1. Adjusted the position of some macros in kclvm-parser. What: 1. Move some util macros for ast from kclvm-parser to kclvm-ast, and add some new util methods in kclvm-ast. How: 1. Move macros "node_ref", "expr_as" and "stmt_as" form from kclvm-parser/mod.rs to kclvm-ast/lib.rs 2. Add method "build_assign_node" in kclvm-ast/lib.rs in order to construct an AssignStmt 3. Add method "filter_schema_stmt_from_module" in kclvm-ast/ast.rs in order to select all "SchemaStmt" in "Module". 4. Add method "TryFrom<...>" in kclvm-ast/ast.rs for "StringLit" and "NameConstant" in order to convert from rust string and bool to kclvm ast. Why: 1. Adjust the structure of the kclvm-ast and add some util methods to continuously enrich the infrastructure of KCLVM to support the development.
zong-zhe
force-pushed
the
dev/zong-zhe/add_utils_to_ast
branch
from
ad3f991
to
2d19a3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor: adjusted some macros in kclvm-parser and add some methods in kclvm-ast
Note:
What:
and add some new util methods in kclvm-ast.
How:
kclvm-parser/mod.rs to kclvm-ast/lib.rs
construct an AssignStmt
in order to select all "SchemaStmt" in "Module".
"NameConstant" in order to convert from rust string and bool to
kclvm ast.
Why:
continuously enrich the infrastructure of KCLVM to support the
development.
main