Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add hints for schema args #1595

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Conversation

shruti2522
Copy link
Contributor

@shruti2522 shruti2522 commented Aug 22, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

2. What is the scope of this PR (e.g. component or file name):

kclvm/sema/src/advanced_resolver/node.rs
kclvm/tools/src/LSP/src/inlay_hints.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

imageedit_2_7210082799

imageedit_4_5242249272

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

Signed-off-by: shruti2522 <shruti.apc01@gmail.com>
@Peefy Peefy merged commit 8f0671a into kcl-lang:main Aug 23, 2024
10 of 12 checks passed
shruti2522 added a commit to shruti2522/kcl that referenced this pull request Aug 26, 2024
add hints for schema args

Signed-off-by: shruti2522 <shruti.apc01@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Add inlay hints for schema arguments.
2 participants