Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unification statement resolve with package schema. #159

Merged
merged 1 commit into from
Aug 18, 2022

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Aug 17, 2022

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

fix: KusionStack/konfig#28

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

test cases at

  • test/grammar/unification/pkg_schema_0
  • test/grammar/unification/pkg_schema_1

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@Peefy Peefy added semantic Issues or PRs related to kcl semantic and checker resolver labels Aug 17, 2022
@Peefy Peefy added this to the v0.4.3 Release milestone Aug 17, 2022
@Peefy Peefy self-assigned this Aug 17, 2022
@Peefy Peefy changed the title [WIP] fix: unification statement resolve with package schema. fix: unification statement resolve with package schema. Aug 17, 2022
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 2873292257

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.005%) to 59.551%

Files with Coverage Reduction New Missed Lines %
kclvm/compiler/src/codegen/llvm/context.rs 2 74.15%
Totals Coverage Status
Change from base Build 2872238247: -0.005%
Covered Lines: 22391
Relevant Lines: 37600

💛 - Coveralls

Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@He1pa He1pa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit c752099 into kcl-lang:main Aug 18, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Aug 18, 2022
@Peefy Peefy deleted the fix-unification-value-name-ty branch August 18, 2022 13:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
resolver semantic Issues or PRs related to kcl semantic and checker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bugfix] Mixin use pkg.identfier merge error
4 participants