Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add warning kind diagnostic #157

Merged
merged 1 commit into from
Aug 17, 2022
Merged

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Aug 16, 2022

Add warning kind diagnostics to build kclvm warning.

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

2. What is the scope of this PR (e.g. component or file name):

error/src/error.rs
error/src/diagnostic.rs
error/src/lib.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
    add doc test in error/src/lib.rs

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Add warning kind diagnostics to build kclvm warning.
@He1pa He1pa added this to the v0.4.3 Release milestone Aug 16, 2022
@He1pa He1pa self-assigned this Aug 16, 2022
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 2867588830

  • 0 of 18 (0.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.6%) to 58.992%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/error/src/error.rs 0 8 0.0%
kclvm/error/src/lib.rs 0 10 0.0%
Totals Coverage Status
Change from base Build 2861308171: -0.6%
Covered Lines: 21364
Relevant Lines: 36215

💛 - Coveralls

Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zong-zhe zong-zhe self-requested a review August 17, 2022 01:43
@He1pa He1pa merged commit cf760e7 into kcl-lang:main Aug 17, 2022
@He1pa He1pa deleted the feat_add_warning_diags branch August 17, 2022 01:50
@github-actions github-actions bot locked and limited conversation to collaborators Aug 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants