Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove in-place union operator |= UI test cases. #155

Merged
merged 1 commit into from
Aug 18, 2022

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Aug 16, 2022

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

re: #143

Remove the |= operator to configure the semantics of in-place merge, and use the : merge attribute operator instead
Remove or modify test cases related to |= operator

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

Motivations: Unify the concept of "configuration unification" in KCL, remove redundant operators. More info ref: https://kusionstack.io/docs/reference/lang/lang/tour#%E9%85%8D%E7%BD%AE%E6%93%8D%E4%BD%9C

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

Remove or modify test cases related to |= operator in the tests folder.

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@Peefy Peefy added the semantic Issues or PRs related to kcl semantic and checker label Aug 16, 2022
@Peefy Peefy self-assigned this Aug 16, 2022
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 2865250775

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 6 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 59.563%

Files with Coverage Reduction New Missed Lines %
kclvm/sema/src/resolver/calculation.rs 6 62.87%
Totals Coverage Status
Change from base Build 2861308171: -0.02%
Covered Lines: 22385
Relevant Lines: 37582

💛 - Coveralls

Copy link
Contributor

@ldxdl ldxdl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@He1pa He1pa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 5e0ec29 into kcl-lang:main Aug 18, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Aug 18, 2022
@Peefy Peefy deleted the refactor-remove-inplace-union-test-cases branch November 4, 2022 12:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
semantic Issues or PRs related to kcl semantic and checker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants