Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enhance runtime type cast and check for lambda arguments and return values #1529

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Jul 31, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

re #1527

feat: enhance runtime type cast and check for lambda arguments and return values

…turn values

Signed-off-by: peefy <xpf6677@163.com>
@Peefy Peefy force-pushed the enhance-runtime-type-cast-for-lambda branch from 3e81acc to 93fd656 Compare August 1, 2024 10:24
@coveralls
Copy link
Collaborator

coveralls commented Aug 1, 2024

Pull Request Test Coverage Report for Build 10196544408

Details

  • 80 of 96 (83.33%) changed or added relevant lines in 5 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.03%) to 70.342%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/evaluator/src/func.rs 3 4 75.0%
kclvm/sema/src/resolver/ty_erasure.rs 19 20 95.0%
kclvm/runtime/src/value/val_type.rs 5 9 55.56%
kclvm/compiler/src/codegen/llvm/node.rs 36 46 78.26%
Files with Coverage Reduction New Missed Lines %
kclvm/evaluator/src/node.rs 1 65.12%
Totals Coverage Status
Change from base Build 10174326375: 0.03%
Covered Lines: 54265
Relevant Lines: 77144

💛 - Coveralls

Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@He1pa He1pa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit fe15ef9 into kcl-lang:main Aug 1, 2024
10 of 12 checks passed
@Peefy Peefy deleted the enhance-runtime-type-cast-for-lambda branch August 1, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants