Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor(compiler-base): Replaced DiagnosticStyle in trait Component with generic T: Clone + PartialEq + Eq + Style. #152

Merged
merged 5 commits into from
Aug 15, 2022
Merged

Conversation

zong-zhe
Copy link
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

issue #115

2. What is the scope of this PR (e.g. component or file name):

compiler_base/error/diagnostic

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

Replaced DiagnosticStyle in trait Component with generic T: Clone + PartialEq + Eq + Style, So that Components can support more Styles.

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

compiler_base/error/diagnostic/tests.rs

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

…nt` with generic `T: Clone + PartialEq + Eq + Style`.

Replaced `DiagnosticStyle` in `trait Component` with generic `T: Clone + PartialEq + Eq + Style`, So that `Components` can support more Styles.

issue #115
@zong-zhe zong-zhe added enhancement New feature or request error-handling Issues or PRs related to kcl error handling refactor labels Aug 15, 2022
@zong-zhe zong-zhe added this to the v0.4.3 Release milestone Aug 15, 2022
@zong-zhe zong-zhe self-assigned this Aug 15, 2022
@coveralls
Copy link
Collaborator

coveralls commented Aug 15, 2022

Pull Request Test Coverage Report for Build 2860650937

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 59.579%

Totals Coverage Status
Change from base Build 2860636643: 0.0%
Covered Lines: 22391
Relevant Lines: 37582

💛 - Coveralls

@ldxdl
Copy link
Contributor

ldxdl commented Aug 15, 2022

LGTM

@zong-zhe zong-zhe requested review from coveralls and removed request for coveralls August 15, 2022 12:28
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kclvm/compiler_base/error/src/diagnostic/components.rs Outdated Show resolved Hide resolved
@Peefy Peefy merged commit c5bb5ad into kcl-lang:main Aug 15, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Aug 15, 2022
@zong-zhe zong-zhe deleted the refactor_diagnostic_component branch September 1, 2022 08:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request error-handling Issues or PRs related to kcl error handling refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants