Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: capi input arguments #1517

Merged
merged 1 commit into from
Jul 24, 2024
Merged

fix: capi input arguments #1517

merged 1 commit into from
Jul 24, 2024

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Jul 24, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y
  • fix: capi input arguments

Added 'args length' to the input parameters of CAPI, as there may be '0' in the bytes of protobuf serialization.

Signed-off-by: peefy <xpf6677@163.com>
Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link
Collaborator

coveralls commented Jul 24, 2024

Pull Request Test Coverage Report for Build 10071572090

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 129 of 187 (68.98%) changed or added relevant lines in 3 files are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.006%) to 70.247%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/api/src/lib.rs 0 8 0.0%
kclvm/api/src/service/capi.rs 104 154 67.53%
Files with Coverage Reduction New Missed Lines %
kclvm/api/src/service/capi.rs 5 70.67%
Totals Coverage Status
Change from base Build 10059950950: -0.006%
Covered Lines: 53972
Relevant Lines: 76832

💛 - Coveralls

@Peefy Peefy merged commit 411156d into kcl-lang:main Jul 24, 2024
12 checks passed
@Peefy Peefy deleted the fix-capi-input-args branch July 24, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants