Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: schema attribute symbol defined in the unification stmt #1516

Merged

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Jul 23, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

Close #1484

  • fix: schema attribute symbol defined in the unification stmt

@coveralls
Copy link
Collaborator

coveralls commented Jul 23, 2024

Pull Request Test Coverage Report for Build 10059150579

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 73 of 78 (93.59%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 70.361%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/sema/src/advanced_resolver/node.rs 48 53 90.57%
Totals Coverage Status
Change from base Build 10037341817: 0.03%
Covered Lines: 53496
Relevant Lines: 76031

💛 - Coveralls

@Peefy Peefy merged commit 988b907 into kcl-lang:main Jul 23, 2024
12 checks passed
@Peefy Peefy deleted the fix-schema-attr-symbol-on-unification-stmt branch July 23, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Newline completion items loss the attribute that is defined in unification stmt of the schema stmt
2 participants