Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(v0.10.0-alpha.1): support multiple assign target including member access a.b and index a[b] #1512

Merged
merged 3 commits into from
Jul 23, 2024

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Jul 19, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

Closes #1396

  • feat: support multiple assign target including member access a.b and index a[b]

2. What is the scope of this PR (e.g. component or file name):

  • Changes on AST, AST walker, AST printer
    • kclvm/ast/src/ast.rs
    • kclvm/ast/src/walker.rs
    • kclvm/ast_pretty/src/node.rs
  • Changes on Parser
    • kclvm/parser/src/parser/expr.rs
    • kclvm/parser/src/parser/stmt.rs
    • ...
  • Changes on Sema
    • kclvm/sema/src/resolver/node.rs
    • ...
  • Changes on Evaluator
    • kclvm/evaluator/src/node.rs
    • kclvm/evaluator/src/scope.rs
    • ...

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
  • kclvm/evaluator/src/snapshots/kclvm_evaluator__tests__**
  • test/grammar/assign/**

…d index `a[b]`

Signed-off-by: peefy <xpf6677@163.com>
@Peefy Peefy added semantic Issues or PRs related to kcl semantic and checker lang-design Issues or PRs related to kcl language design and KEPs feat labels Jul 19, 2024
@Peefy Peefy added this to the v0.10.0 Release milestone Jul 19, 2024
Signed-off-by: peefy <xpf6677@163.com>
Signed-off-by: peefy <xpf6677@163.com>
@coveralls
Copy link
Collaborator

coveralls commented Jul 19, 2024

Pull Request Test Coverage Report for Build 10010023855

Details

  • 824 of 1133 (72.73%) changed or added relevant lines in 39 files are covered.
  • 75 unchanged lines in 6 files lost coverage.
  • Overall coverage decreased (-0.09%) to 71.581%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/query/src/node.rs 2 3 66.67%
kclvm/runtime/src/_kclvm_addr.rs 0 1 0.0%
kclvm/runtime/src/value/val_as_val.rs 4 5 80.0%
kclvm/sema/src/resolver/var.rs 31 32 96.88%
kclvm/api/src/service/jsonrpc.rs 0 2 0.0%
kclvm/sema/src/namer/node.rs 8 11 72.73%
kclvm/evaluator/src/scope.rs 57 61 93.44%
kclvm/runtime/src/value/val_bin.rs 8 17 47.06%
kclvm/tools/src/LSP/src/util.rs 1 10 10.0%
kclvm/parser/src/parser/expr.rs 46 56 82.14%
Files with Coverage Reduction New Missed Lines %
kclvm/sema/src/resolver/var.rs 1 92.39%
kclvm/sema/src/resolver/node.rs 1 82.0%
kclvm/evaluator/src/node.rs 1 65.06%
kclvm/sema/src/advanced_resolver/node.rs 4 81.98%
kclvm/ast/src/ast.rs 12 80.51%
kclvm/compiler/src/codegen/llvm/node.rs 56 88.17%
Totals Coverage Status
Change from base Build 9974038893: -0.09%
Covered Lines: 57697
Relevant Lines: 80604

💛 - Coveralls

@Peefy Peefy requested review from zong-zhe and He1pa July 19, 2024 15:22
Copy link
Contributor

@He1pa He1pa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy changed the title feat: support multiple assign target including member access a.b and index a[b] feat(v0.10.0-alpha.1): support multiple assign target including member access a.b and index a[b] Jul 22, 2024
@Peefy Peefy merged commit d53b518 into kcl-lang:main Jul 23, 2024
12 checks passed
@Peefy Peefy deleted the feat-assign-index-target branch July 23, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat lang-design Issues or PRs related to kcl language design and KEPs semantic Issues or PRs related to kcl semantic and checker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

K8s YAML templating: Updating keys with dots/special characters
3 participants