Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix schema index signature type check #1450

Merged
merged 2 commits into from
Jun 28, 2024

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Jun 27, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

kclvm/sema/src/resolver/ty.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

Signed-off-by: he1pa <18012015693@163.com>
@He1pa He1pa added resolver type-system Issues or PRs related to kcl type system labels Jun 27, 2024
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Catch! LGTM!

@Peefy
Copy link
Contributor

Peefy commented Jun 27, 2024

Grammar CI failed. cc @He1pa

Signed-off-by: he1pa <18012015693@163.com>
@Peefy Peefy merged commit 84b40c7 into kcl-lang:main Jun 28, 2024
8 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
resolver type-system Issues or PRs related to kcl type system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants