Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix resolver cache caused falsely report errors. #1320

Merged
merged 1 commit into from
May 16, 2024

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented May 16, 2024

fix resolver cache caused falsely report errors. Add schema mapping to resolver cache

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

2. What is the scope of this PR (e.g. component or file name):

kclvm/sema/src/resolver/mod.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

fix resolver cache caused falsely report errors. Add schema mapping to resolver cache

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@He1pa He1pa added bug Something isn't working fix resolver lsp labels May 16, 2024
…ing to resolver cache

Signed-off-by: he1pa <18012015693@163.com>
@He1pa He1pa force-pushed the fix_resolver_cache_schema_ty branch from ed4bfb4 to 751430d Compare May 16, 2024 06:20
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link
Collaborator

coveralls commented May 16, 2024

Pull Request Test Coverage Report for Build 9107481181

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 5 of 5 (100.0%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 71.054%

Files with Coverage Reduction New Missed Lines %
kclvm/sema/src/resolver/config.rs 2 80.55%
Totals Coverage Status
Change from base Build 9096033782: 0.0%
Covered Lines: 53603
Relevant Lines: 75440

💛 - Coveralls

@Peefy Peefy merged commit 1caf867 into kcl-lang:main May 16, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fix lsp resolver
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Compile Cache causes lsp falsely report errors
3 participants