Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:Lsp compile unit cache watcher for config file(kcl.yaml and kcl.mod). #1188

Merged
merged 4 commits into from
Apr 7, 2024

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Apr 2, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

kclvm/tools/src/LSP/src/*

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

feat: lsp compile unit cache.
Add watcher for config file(kcl.mod and kcl.yaml). clear cache when edit config files.

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

kclvm/tools/src/LSP/src/state.rs Outdated Show resolved Hide resolved
kclvm/tools/src/LSP/src/state.rs Outdated Show resolved Hide resolved
@coveralls
Copy link
Collaborator

coveralls commented Apr 2, 2024

Pull Request Test Coverage Report for Build 8586641910

Details

  • 171 of 171 (100.0%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 71.839%

Totals Coverage Status
Change from base Build 8586586524: 0.1%
Covered Lines: 47935
Relevant Lines: 66726

💛 - Coveralls

@Peefy Peefy changed the title [wip] feat:Lsp compile unit cache [wip] feat:Lsp compile unit cache watcher for config file(kcl.yaml and kcl.mod). Apr 2, 2024
@He1pa He1pa changed the title [wip] feat:Lsp compile unit cache watcher for config file(kcl.yaml and kcl.mod). feat:Lsp compile unit cache watcher for config file(kcl.yaml and kcl.mod). Apr 3, 2024
@He1pa He1pa marked this pull request as ready for review April 3, 2024 09:22
kclvm/tools/src/LSP/src/request.rs Show resolved Hide resolved
kclvm/tools/src/LSP/src/util.rs Outdated Show resolved Hide resolved
…watcher for config file(`kcl.yaml` and `kcl.mod`).

Signed-off-by: he1pa <18012015693@163.com>
Signed-off-by: he1pa <18012015693@163.com>
Signed-off-by: he1pa <18012015693@163.com>
Signed-off-by: he1pa <18012015693@163.com>
@Peefy Peefy added enhancement New feature or request langserver labels Apr 7, 2024
@Peefy Peefy added this to the v0.9.0 Release milestone Apr 7, 2024
@Peefy Peefy merged commit 00eecb6 into kcl-lang:main Apr 7, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request langserver
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants