Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add grammar and runtime tests on rust kclvm in the github acti… #113

Merged
merged 1 commit into from
Jul 15, 2022

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Jul 13, 2022

…ons and remove deprecated test cases.

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

re #50

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other
  • Add kclvm rust runtime tests with python test suites to CI
  • Add grammar tests to CI
  • Remove outdated grammar tests

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

At kclvm, run grammar test

make test-grammar

At kclvm, run runtime test

make test-runtime

In this PR, add these tests into CI.

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@Peefy Peefy added enhancement New feature or request test ci labels Jul 13, 2022
@Peefy Peefy added this to the v0.4.3 Release milestone Jul 13, 2022
@Peefy Peefy requested review from chai2010 and zong-zhe July 13, 2022 13:50
@Peefy Peefy self-assigned this Jul 13, 2022
@Peefy Peefy changed the title tests: add grammar and runtime tests on rust kclvm in the github acti… test: add grammar and runtime tests on rust kclvm in the github acti… Jul 13, 2022
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 2663885177

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.4%) to 51.837%

Totals Coverage Status
Change from base Build 2649077295: -0.4%
Covered Lines: 18652
Relevant Lines: 35982

💛 - Coveralls

Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy requested a review from He1pa July 15, 2022 02:17
Copy link
Contributor

@He1pa He1pa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 60883c6 into kcl-lang:main Jul 15, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jul 15, 2022
@Peefy Peefy deleted the test-refactor-grammar-test-suite branch November 4, 2022 12:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ci enhancement New feature or request test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants