Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enhance plugin agent flag in APIs #1050

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Feb 19, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

  • kclvm/api/src/service/service_impl.rs
  • kclvm/api/src/service/util.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

Signed-off-by: peefy <xpf6677@163.com>
@Peefy Peefy added refactor api Issues or PRs related to kcl rust native APIs and multi-lang APIs labels Feb 19, 2024
@Peefy Peefy added this to the v0.8.0 Release milestone Feb 19, 2024
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 7953790579

Details

  • -2 of 11 (81.82%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.001%) to 72.295%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/api/src/service/service_impl.rs 5 7 71.43%
Totals Coverage Status
Change from base Build 7948623196: -0.001%
Covered Lines: 43899
Relevant Lines: 60722

💛 - Coveralls

Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit e5082d0 into kcl-lang:main Feb 19, 2024
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api Issues or PRs related to kcl rust native APIs and multi-lang APIs refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants