Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix schema scope variables sema info and comments symbols panic #1014

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Jan 29, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

2. What is the scope of this PR (e.g. component or file name):

kclvm/sema/src/advanced_resolver/node.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@He1pa He1pa added semantic Issues or PRs related to kcl semantic and checker lsp labels Jan 29, 2024
@He1pa He1pa force-pushed the fix_schema_scope_variables_sema_info branch from 337af62 to 6930c14 Compare January 29, 2024 11:27
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 7695301173

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 79 unchanged lines in 6 files lost coverage.
  • Overall coverage increased (+15.5%) to 87.787%

Files with Coverage Reduction New Missed Lines %
compiler_base/error/src/diagnostic/diagnostic_message.rs 3 96.1%
compiler_base/span/src/span.rs 3 0.0%
compiler_base/error/src/unit_type.rs 5 0.0%
compiler_base/session/src/lib.rs 15 75.81%
compiler_base/error/src/diagnostic/components.rs 23 81.01%
compiler_base/error/src/diagnostic/diagnostic_handler.rs 30 82.13%
Totals Coverage Status
Change from base Build 7693976016: 15.5%
Covered Lines: 2293
Relevant Lines: 2612

💛 - Coveralls

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 7695322708

  • -2 of 16 (87.5%) changed or added relevant lines in 3 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.01%) to 72.322%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/sema/src/advanced_resolver/node.rs 11 12 91.67%
kclvm/tools/src/LSP/src/hover.rs 2 3 66.67%
Files with Coverage Reduction New Missed Lines %
kclvm/tools/src/LSP/src/completion.rs 3 90.98%
Totals Coverage Status
Change from base Build 7693976016: 0.01%
Covered Lines: 43755
Relevant Lines: 60500

💛 - Coveralls

Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 86e7134 into kcl-lang:main Jan 29, 2024
10 of 11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lsp semantic Issues or PRs related to kcl semantic and checker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants