Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Broken pipe in FormatPath #94

Merged
merged 2 commits into from
Apr 2, 2023
Merged

fix: Broken pipe in FormatPath #94

merged 2 commits into from
Apr 2, 2023

Conversation

jakezhu9
Copy link
Contributor

@jakezhu9 jakezhu9 commented Apr 2, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

fix #75

2. What is the scope of this PR (e.g. component or file name):

KusionStack/kclvm-go/pkg/kclvm_runtime/proc.go

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4589493358

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 47.698%

Totals Coverage Status
Change from base Build 4508597840: 0.1%
Covered Lines: 2673
Relevant Lines: 5604

💛 - Coveralls

@Peefy Peefy added the bug Something isn't working label Apr 2, 2023
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job! LGTM!

@Peefy Peefy merged commit 50753f3 into kcl-lang:main Apr 2, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestFormatPath Failed
3 participants