Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: impl kcl openapi schema generation with kcl decorators #206

Merged
merged 2 commits into from
Jan 8, 2024

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Jan 8, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix kcl-lang/kcl#123", "re kcl-lang/kcl#123".):

  • N
  • Y

re kcl-lang/backstage-kcl#2

feat: impl kcl openapi schema generation with kcl decorators

2. What is the scope of this PR (e.g. component or file name):

  • go.mod
  • pkg/tools/gen/gendoc.go
  • pkg/tools/gen/genopenapi.go

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
  • pkg/tools/gen/genopenapi_test.go

@Peefy Peefy requested a review from zong-zhe January 8, 2024 09:52
@Peefy Peefy force-pushed the gen-openapi-schema-with-kcl-decorator branch from 929e332 to 6b08204 Compare January 8, 2024 09:57
@Peefy Peefy added the tool label Jan 8, 2024
@Peefy Peefy force-pushed the gen-openapi-schema-with-kcl-decorator branch from 6b08204 to dbd0055 Compare January 8, 2024 10:03
Signed-off-by: peefy <xpf6677@163.com>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7445945136

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 63.134%

Totals Coverage Status
Change from base Build 7343717484: 0.2%
Covered Lines: 2877
Relevant Lines: 4557

💛 - Coveralls

@Peefy Peefy merged commit 6bb63b7 into kcl-lang:main Jan 8, 2024
7 checks passed
@Peefy Peefy deleted the gen-openapi-schema-with-kcl-decorator branch January 8, 2024 11:03
@github-actions github-actions bot locked and limited conversation to collaborators Jan 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants