Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support logger opts to merge #186

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Nov 27, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y
  • feat: support logger opts to merge

2. What is the scope of this PR (e.g. component or file name):

  • pkg/kcl/api.go
  • pkg/kcl/opt.go

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

Signed-off-by: peefy <xpf6677@163.com>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6999830894

  • 2 of 7 (28.57%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 62.993%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/kcl/opt.go 2 3 66.67%
pkg/kcl/api.go 0 4 0.0%
Totals Coverage Status
Change from base Build 6976744194: -0.02%
Covered Lines: 2681
Relevant Lines: 4256

💛 - Coveralls

@Peefy Peefy merged commit 0b7e384 into kcl-lang:main Nov 27, 2023
7 checks passed
@Peefy Peefy deleted the support-logger-opts-merge branch November 27, 2023 02:29
@github-actions github-actions bot locked and limited conversation to collaborators Nov 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support Go API for GetSchemaTypeMapping
2 participants