Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: crd groupby logic #133

Merged
merged 1 commit into from
Aug 14, 2024
Merged

fix: crd groupby logic #133

merged 1 commit into from
Aug 14, 2024

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Aug 14, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

re kcl-lang/kcl#1542

fix: crd groupby logic

Signed-off-by: peefy <xpf6677@163.com>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10381060347

Details

  • 0 of 3 (0.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 14.214%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/options/import.go 0 1 0.0%
pkg/import/crd/groupby.go 0 2 0.0%
Totals Coverage Status
Change from base Build 10364670523: -0.02%
Covered Lines: 85
Relevant Lines: 598

💛 - Coveralls

Copy link

@He1pa He1pa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants