Add health check for redmine services #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v2.x #410 +/- ##
=========================================
Coverage 98.49% 98.50%
- Complexity 619 623 +4
=========================================
Files 29 29
Lines 1866 1876 +10
=========================================
+ Hits 1838 1848 +10
Misses 28 28 ☔ View full report in Codecov by Sentry. |
Art4
added a commit
to Art4/php-redmine-api
that referenced
this pull request
Jul 5, 2024
Pinging the redmine server for the health check create a new AnonymousUser with id 4 refs kbsali#410
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working with Behat I've sometimes forget to start the docker services. If I run the Behat tests I see all tests failing because of the missing redmine services.
This PR adds a health check for the Redmine server running upfront the Behat tests. The tests wont start if the Redmine service or database isn't accessible and a proper error message will be shown. It also simplifies the procedure to add or update the Redmine server versions for Behat tests.