Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.4 Fix implicitly nullable parameter declarations deprecations #407

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

Art4
Copy link
Collaborator

@Art4 Art4 commented Jun 27, 2024

This PR fixes the PHP 8.4 deprecation warnings for implicitly nullable parameter declarations, see https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated

PHP 8.4 deprecates implicitly nullable types. PHP applications are recommended to explicitly declare the type as nullable. All type declarations that have a default value of null, but without declaring null in the type declaration emit a deprecation notice

@Art4 Art4 added this to the v2.7.0 milestone Jun 27, 2024
@Art4 Art4 self-assigned this Jun 27, 2024
@Art4 Art4 requested a review from kbsali June 27, 2024 14:39
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.47%. Comparing base (31768d5) to head (cc14f15).

Additional details and impacted files
@@            Coverage Diff            @@
##               v2.x     #407   +/-   ##
=========================================
  Coverage     98.47%   98.47%           
  Complexity      609      609           
=========================================
  Files            29       29           
  Lines          1841     1841           
=========================================
  Hits           1813     1813           
  Misses           28       28           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Art4 Art4 merged commit be7c256 into kbsali:v2.x Jun 27, 2024
12 checks passed
@Art4 Art4 deleted the fix-php84-deprecation-warnings branch June 27, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants