Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test handling attachments with wiki pages #377

Merged
merged 14 commits into from
Feb 8, 2024
Merged

Conversation

Art4
Copy link
Collaborator

@Art4 Art4 commented Feb 5, 2024

This PR adds end2end tests for handling wiki pages and attachments as a preparation for implementing attachment updates, see #320

It also fixes #374.

@Art4 Art4 added this to the v2.6.0 milestone Feb 5, 2024
@Art4 Art4 self-assigned this Feb 5, 2024
@Art4 Art4 changed the title Add end2end test for handling attachments with wiki pages Test handling attachments with wiki pages Feb 5, 2024
Copy link

codecov bot commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6083781) 97.63% compared to head (789efb3) 97.63%.

Additional details and impacted files
@@            Coverage Diff            @@
##               v2.x     #377   +/-   ##
=========================================
  Coverage     97.63%   97.63%           
  Complexity      563      563           
=========================================
  Files            29       29           
  Lines          1607     1609    +2     
=========================================
+ Hits           1569     1571    +2     
  Misses           38       38           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Art4 Art4 marked this pull request as ready for review February 8, 2024 08:57
@Art4 Art4 requested a review from kbsali February 8, 2024 08:57
@Art4 Art4 merged commit 6a4e464 into kbsali:v2.x Feb 8, 2024
12 checks passed
@Art4 Art4 deleted the wiki-attachments branch February 8, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wiki page title must be urlencoded
2 participants