Add Request
interface and rename Response::getBody()
#366
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the
HttpClient::request()
method to allow handling implementation of the newRequest
interface, described in #341. It also renamesResponse::getBody()
toResponse::getContent()
, see #363.In the tests I introduced an
AssertingHttpClient
that allows us easily define aHttpClient
with asserted Requests and expected Responses. This will become very handy while starting deprecating theRedmine\Client\Client
interface and replacing it in tests.