Move code-quality checks into separate Github action tasks #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v2.x #358 +/- ##
=========================================
Coverage 96.71% 96.71%
Complexity 534 534
=========================================
Files 27 27
Lines 1459 1459
=========================================
Hits 1411 1411
Misses 48 48 ☔ View full report in Codecov by Sentry. |
kbsali
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed that sometimes the tests with PHP 8.3 fail because of issues with the upload to codecov. This is misleading, because seeing a failed test with PHP 8.3 I assume that there is something wrong with the code.
In this PR I've split the Github action tasks into tests (with PHPUnit) and code-quality checks (phpstan, code-coverage). I've also added a new check for code-sytle using php-cs-fixer.
This way we will see at first glance what's the problem with a broken task.