Skip to content
This repository has been archived by the owner on Feb 25, 2020. It is now read-only.

Opening a repo without logging in doesn't draw the diagram #215

Open
dcho415 opened this issue Apr 6, 2019 · 3 comments
Open

Opening a repo without logging in doesn't draw the diagram #215

dcho415 opened this issue Apr 6, 2019 · 3 comments
Assignees
@pqua613
Labels
Approved Small Transferred

Comments

@dcho415
Copy link
Collaborator

dcho415 commented Apr 6, 2019

Opening a local repository when you're not logged in doesn't draw the graph. It just says the application is 'Opening Local Repository' and never finishes the graph. You can still close the modal and it still shows the files that have been changed, but the graph is just missing.

Steps to reproduce:

  1. Open the application
  2. Click 'Continue without sign in'
  3. Open a local repository

Actual:
image

Expected:
Should still show this even if you're not logged in.
image
@ktam069
Copy link
Collaborator

ktam069 commented Apr 6, 2019

Approve

@dcho415 dcho415 added the Small label Apr 6, 2019
@ylee778
Copy link
Collaborator

ylee778 commented Apr 6, 2019

approve

@Pathical
Copy link
Collaborator

Pathical commented Apr 6, 2019

Approved

@pqua613 pqua613 self-assigned this Apr 6, 2019
@pqua613 pqua613 mentioned this issue Apr 6, 2019
Merged
BennyChun pushed a commit that referenced this issue Apr 7, 2019
@pqua613 @BennyChun
[#215] Issue 215 fixed, cloning local draws graph
8ddbba2 
* Fixed graph drawing being stopped due to GitHub API call.

* Added error handling for GitHub API call. Changed variable names to be more meaningful
@James-Ansley James-Ansley mentioned this issue Apr 11, 2019
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pqua613 pqua613

Labels
Approved Small Transferred
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@jtiz003 @Pathical @ktam069 @dcho415 @ylee778 @pqua613