Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge to main for 5.4.0 release #3603

Merged
merged 40 commits into from
Jul 25, 2024
Merged

Merge to main for 5.4.0 release #3603

merged 40 commits into from
Jul 25, 2024

Conversation

briehl
Copy link
Member

@briehl briehl commented Jul 25, 2024

Description of PR purpose/changes

As the title says, just merging up develop -> main.

briehl and others added 30 commits June 18, 2024 11:07
UIP-43 Change Narrative JSON downloads to use a download-to-staging app
UIP-43 include tests for errors, downloader logs
UIP-44 Convert DIE download URL to Blobstore
UIP-43 fix printed warning when running an app with a wildcard allowed type
use main/master version for GHAs
UIP-45 update the report widget to use the new blobstore links for file downloads
Copy link

sonarcloud bot commented Jul 25, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
3.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link

codecov bot commented Jul 25, 2024

Codecov Report

Attention: Patch coverage is 93.39623% with 7 lines in your changes missing coverage. Please review.

Project coverage is 25.92%. Comparing base (6eb978a) to head (d89aae3).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3603      +/-   ##
==========================================
+ Coverage   25.71%   25.92%   +0.20%     
==========================================
  Files         461      461              
  Lines       46694    46652      -42     
==========================================
+ Hits        12009    12094      +85     
+ Misses      34685    34558     -127     
Files Coverage Δ
...tic/kbase/js/common/cellComponents/tabs/infoTab.js 100.00% <100.00%> (ø)
kbase-extension/static/kbase/js/common/data.js 100.00% <100.00%> (ø)
...base/js/widgets/function_output/kbaseReportView.js 90.15% <100.00%> (-0.11%) ⬇️
...s/widgets/narrative_core/kbaseNarrativeDataList.js 48.78% <ø> (ø)
...bextensions/appCell2/widgets/tabs/resultsViewer.js 95.18% <100.00%> (+0.58%) ⬆️
nbextensions/appCell2/widgets/appCellWidget.js 63.77% <0.00%> (-0.13%) ⬇️
...gets/narrative_core/kbaseNarrativeDownloadPanel.js 94.78% <94.31%> (+70.23%) ⬆️

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6eb978a...d89aae3. Read the comment docs.

@briehl briehl merged commit c1b3675 into main Jul 25, 2024
5 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants