Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge to main to release v5.3.0 #3567

Merged
merged 162 commits into from
Jun 26, 2024
Merged

Merge to main to release v5.3.0 #3567

merged 162 commits into from
Jun 26, 2024

Conversation

briehl
Copy link
Member

@briehl briehl commented Jun 25, 2024

Description of PR purpose/changes

As it says above! Check the release notes for changes.

eapearson and others added 30 commits January 3, 2023 09:03
…TV-1845]

includes enhanced tests and additional instructions for testing with docker containers
Removing some comments and an extraneous method; general tidying
DATAUP-765: add user and wsid to job output
Removing some comments and an extraneous method; general tidying
The existing one is not AMD, but I didn't want to update it and then have to potentially touch all the code that uses it. This was also a chance to make the kbasePrompt a bit more reasonable as a base for creating specific prompts, like the Confirmation Prompt used by the tabs.
I think it is critical to have this in the codebase; otherwise, how is one to "see" what the widgets do in each of their possible, or at least common, configurations?
Similar to the similar utility in testing library, it tries looking for a text within an element for a given period of time with a given frequency
makes testing easier, and does not interfere with real usage.
ialarmedalien and others added 26 commits June 4, 2024 11:50
UIP-47: Updating clustergrammer widget to v2 and un-skip clustergrammer test
…ingleton directories with the different clients in them.
adding some python updates that didn't make it into the previous PR
updating that accursed release notes file
…src/ folder for ease of updating, and updating the docs accordingly.

also added some typing to some python files
edited dockerfile to transfer over individual folders instead of copying the whole repo and creating an image with a load of unnecessary junk in it.
UIP-47: Updating versions of github actions
UIP-47: Simplify narrative installation
UIP-45 - add regression test for download path from report
Copy link

sonarcloud bot commented Jun 25, 2024

Copy link
Collaborator

@ialarmedalien ialarmedalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge away, my good fellow!

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 80.64516% with 30 lines in your changes missing coverage. Please review.

Project coverage is 25.71%. Comparing base (d9ca826) to head (6eb978a).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3567      +/-   ##
==========================================
- Coverage   29.36%   25.71%   -3.66%     
==========================================
  Files         497      461      -36     
  Lines       50580    46694    -3886     
==========================================
- Hits        14855    12009    -2846     
+ Misses      35725    34685    -1040     
Files Coverage Δ
...tic/kbase/js/common/cellComponents/tabs/infoTab.js 100.00% <ø> (ø)
...ion/static/kbase/js/widgets/common/ErrorMessage.js 100.00% <ø> (ø)
...n/static/kbase/js/widgets/common/LoadingMessage.js 100.00% <100.00%> (ø)
...nsion/static/kbase/js/widgets/common/RenderJSON.js 100.00% <100.00%> (ø)
...sion/static/kbase/js/widgets/common/jQueryUtils.js 100.00% <100.00%> (ø)
...gets/narrative_core/kbaseNarrativeSidePublicTab.js 0.96% <ø> (ø)
.../widgets/narrative_core/upload/fileUploadWidget.js 76.92% <100.00%> (ø)
nbextensions/bulkImportCell/tabs/xsvGenerator.js 89.38% <ø> (ø)
kbase-extension/static/kbase/js/api/auth.js 92.30% <66.66%> (+1.39%) ⬆️
...static/kbase/js/widgets/kbaseConfirmationPrompt.js 71.42% <71.42%> (ø)
... and 3 more

... and 42 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9ca826...6eb978a. Read the comment docs.

@briehl briehl merged commit d72573c into main Jun 26, 2024
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants