remove console.log

kbase · Sep 27, 2024 · 8d46c81 · 8d46c81
1 parent c8a333c
commit 8d46c81
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 5 deletions.
diff --git a/eslint.config.mjs b/eslint.config.mjs
@@ -41,8 +41,6 @@ export default [{
     },
 
     rules: {
-        strict: ["error", "function"],
-
         "no-console": ["error", {
             allow: ["warn", "error"],
         }],

diff --git a/kbase-extension/static/kbase/js/api/auth.js b/kbase-extension/static/kbase/js/api/auth.js
@@ -1,4 +1,6 @@
 define(['bluebird', 'jquery', 'narrativeConfig'], (Promise, $, Config) => {
+    'use strict';
+
     function factory(config) {
         const url = config.url;
         const secureCookies =

diff --git a/kbase-extension/static/kbase/js/narrativeLogin.js b/kbase-extension/static/kbase/js/narrativeLogin.js
@@ -14,6 +14,8 @@ define([
     'userMenu',
     'util/bootstrapDialog',
 ], ($, Promise, kbapi, JupyterUtils, Config, Auth, UserMenu, BootstrapDialog) => {
+    'use strict';
+
     const baseUrl = JupyterUtils.get_body_data('baseUrl');
     const authClient = Auth.make({ url: Config.url('auth') });
     let sessionInfo = null;

diff --git a/test/unit/spec/api/authSpec.js b/test/unit/spec/api/authSpec.js
@@ -463,8 +463,9 @@ define(['api/auth', 'narrativeConfig', 'uuid', 'testUtil'], (Auth, Config, Uuid,
             expect(authClient.getCookie(backupCookieName)).toEqual(backupCookieValue);
         });
 
-        it('Should set and clear backup cookie in prod', () => {
+        it('Should set and clear backup cookie in prod', async () => {
             const env = Config.get('environment');
+            const tokenCookie = 'kbase_session';
             const backupCookieName = 'kbase_session_backup';
             if (env !== 'prod') {
                 pending('This test is only valid for a prod config');
@@ -476,14 +477,16 @@ define(['api/auth', 'narrativeConfig', 'uuid', 'testUtil'], (Auth, Config, Uuid,
 
             // Setting an arbitrary token should work.
             const cookieValue = new Uuid(4).format();
-            authClient.setAuthToken(cookieValue);
+            mockAuthRequest('token', makeTokenInfo(), 200);
+            await authClient.setAuthToken(cookieValue);
             expect(authClient.getAuthToken()).toEqual(cookieValue);
+            expect(authClient.getCookie(tokenCookie)).toEqual(cookieValue);
             expect(authClient.getCookie(backupCookieName)).toEqual(cookieValue);
 
             // Clearing an auth token should also work.
             authClient.clearAuthToken();
             expect(authClient.getAuthToken()).toBeNull();
-            expect(authClient.getCookie('kbase_session')).toBeNull();
+            expect(authClient.getCookie(tokenCookie)).toBeNull();
             expect(authClient.getCookie(backupCookieName)).toBeNull();
         });