Merge pull request #105 from kbase/URO-183

use _top not _parent (breaks jgi search tab), use & not ? [URO-183]
kbase · Nov 17, 2023 · 2d59e79 · 2d59e79
2 parents f767a17 + 2d3a152
commit 2d59e79
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/src/plugin/iframe_root/index.html b/src/plugin/iframe_root/index.html
@@ -1,7 +1,7 @@
 <!DOCTYPE html>
 <html lang="en">
     <head>
-        <base target="_parent" />
+        <base target="_top" />
         <meta charset="utf-8" />
         <meta name="viewport" content="width=device-width,initial-scale=1,shrink-to-fit=no" />
         <meta name="theme-color" content="#000000" />

diff --git a/src/plugin/iframe_root/modules/components/navBar.js b/src/plugin/iframe_root/modules/components/navBar.js
@@ -157,11 +157,11 @@ define(['knockout', 'kb_knockout/registry', 'kb_lib/html'], function (ko, reg, h
                     {
                         dataBind: {
                             attr: {
-                                href: '"/#jgi-search?q=" + searchInputQueryValue()'
+                                href: '"/#jgi-search&q=" + searchInputQueryValue()'
                             }
                         },
                         class: styles.classes.navLink,
-                        target: '_parent'
+                        target: '_top'
                     },
                     'JGI'
                 )

diff --git a/src/plugin/iframe_root/modules/lib/types/typeDefs/DefaultSubObjectIndex.js b/src/plugin/iframe_root/modules/lib/types/typeDefs/DefaultSubObjectIndex.js
@@ -33,7 +33,7 @@ define([
             const featureId = 'y'; // m[5];
             // e.g. https://ci.kbase.us/#dataview/29768/2?sub=Feature&subid=b0001
             const subObjectRef = objectRef +
-                            '?sub=' + featureType +
+                            '&sub=' + featureType +
                             '&subid=' + featureId;
 
             // const objectRef = m.slice(1, 4).join('/');