Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CE-311 - logging everywhere #49

Merged
merged 5 commits into from
Oct 20, 2023
Merged

CE-311 - logging everywhere #49

merged 5 commits into from
Oct 20, 2023

Conversation

eapearson
Copy link
Contributor

@eapearson eapearson commented Oct 19, 2023

CE-311 - logging everywhere

A couple weeks ago we added JSON logging in preparation for adding easily-analyzable logging generally and specifically for all ORCID API calls, as they recommend.

This is an effort to complete that logging.

Description

Add logging calls to all ORCID API calls.

Issues Resolved

  • Added the Jira Ticket id(s) to the title of the PR
  • [ ] Added the Github Issue Ids to the title of the PR

Testing Instructions

One needs to have bash and docker installed.

git clone https://github.com/kbase/kbase-service-orcidlink
cd kbase-service-orcidlink
./Taskfile test
  • Tests pass locally
  • Tests and build pass in GitHub actions
  • Manually verified that changes are available (if applicable)

Dev Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have run the code quality tools against the codebase

Release Notes - Development

This section only relevant to a PR against develop

  • Ensure there is an "Unreleased" section located at the top of RELEASE_NOTES.md
  • Add relevant notes to Unreleased

Release

This section only relevant if this PR is preparing a release

  • [ ] Rename the "Unreleased" section to the appropriate release, and create a new, empty "Ureleased" section at the top

@eapearson eapearson merged commit 954a99e into develop Oct 20, 2023
7 checks passed
@eapearson eapearson deleted the CE-311 branch June 28, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant