Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing kb_sdk tests, slimming down dockerfile #370

Merged
merged 9 commits into from
Mar 15, 2023
Merged

Conversation

ialarmedalien
Copy link
Collaborator

@ialarmedalien ialarmedalien commented Mar 7, 2023

Updated the GHA to use modern Ubuntu versions.

Disabled the example SDK repo generation tests as they fail due to the tool that they rely upon no longer being available:

Step 3/8 : RUN cd /kb/deployment/lib/jars     && wget https://downloads.sourceforge.net/project/jfasta/releases/jfasta-2.2.0/jfasta-2.2.0-jar-with-dependencies.jar
[124](https://github.com/kbase/kb_sdk/actions/runs/4356796393/jobs/7615949039#step:10:125)
 ---> Running in 2d4de77d7adf
[125](https://github.com/kbase/kb_sdk/actions/runs/4356796393/jobs/7615949039#step:10:126)
--2023-03-07 17:58:44--  https://downloads.sourceforge.net/project/jfasta/releases/jfasta-2.2.0/jfasta-2.2.0-jar-with-dependencies.jar
[126](https://github.com/kbase/kb_sdk/actions/runs/4356796393/jobs/7615949039#step:10:127)
Resolving downloads.sourceforge.net (downloads.sourceforge.net)... 204.68.111.105
[127](https://github.com/kbase/kb_sdk/actions/runs/4356796393/jobs/7615949039#step:10:128)
Connecting to downloads.sourceforge.net (downloads.sourceforge.net)|204.68.111.105|:443... connected.
[128](https://github.com/kbase/kb_sdk/actions/runs/4356796393/jobs/7615949039#step:10:129)
ERROR: The certificate of ‘downloads.sourceforge.net’ is not trusted.
[129](https://github.com/kbase/kb_sdk/actions/runs/4356796393/jobs/7615949039#step:10:130)
ERROR: The certificate of ‘downloads.sourceforge.net’ has expired.
[130](https://github.com/kbase/kb_sdk/actions/runs/4356796393/jobs/7615949039#step:10:131)
The command '/bin/sh -c cd /kb/deployment/lib/jars     && wget https://downloads.sourceforge.net/project/jfasta/releases/jfasta-2.2.0/jfasta-2.2.0-jar-with-dependencies.jar' returned a non-zero code: 5
[131](https://github.com/kbase/kb_sdk/actions/runs/4356796393/jobs/7615949039#step:10:132)

WSLargeDataIO builds are failing because the Java repo that they rely upon is no longer active:

Step 3/12 : RUN add-apt-repository ppa:openjdk-r/ppa 	&& sudo apt-get update 	&& sudo apt-get -y install openjdk-8-jdk 	&& echo java versions: 	&& java -version 	&& javac -version 	&& echo $JAVA_HOME 	&& ls -l /usr/lib/jvm 	&& cd /kb/runtime 	&& rm java 	&& ln -s /usr/lib/jvm/java-8-openjdk-amd64 java 	&& ls -l
[1023](https://github.com/kbase/kb_sdk/actions/runs/4385984642/jobs/7679423247#step:10:1024)
 ---> Running in 6d825436f373
[1024](https://github.com/kbase/kb_sdk/actions/runs/4385984642/jobs/7679423247#step:10:1025)
Cannot add PPA: 'ppa:openjdk-r/ppa'.
[1025](https://github.com/kbase/kb_sdk/actions/runs/4385984642/jobs/7679423247#step:10:1026)
Please check that the PPA name or format is correct.
[1026](https://github.com/kbase/kb_sdk/actions/runs/4385984642/jobs/7679423247#step:10:1027)
The command '/bin/sh -c add-apt-repository ppa:openjdk-r/ppa 	&& sudo apt-get update 	&& sudo apt-get -y install openjdk-8-jdk 	&& echo java versions: 	&& java -version 	&& javac -version 	&& echo $JAVA_HOME 	&& ls -l /usr/lib/jvm 	&& cd /kb/runtime 	&& rm java 	&& ln -s /usr/lib/jvm/java-8-openjdk-amd64 java 	&& ls -l' returned a non-zero code: 1
[1027](https://github.com/kbase/kb_sdk/actions/runs/4385984642/jobs/7679423247#step:10:1028)
Cleaning up building container: 6d825436f373

@ialarmedalien ialarmedalien changed the title Fixing kb_sdk tests, slimming down dockerfile WIP: Fixing kb_sdk tests, slimming down dockerfile Mar 10, 2023
@ialarmedalien ialarmedalien changed the title WIP: Fixing kb_sdk tests, slimming down dockerfile Fixing kb_sdk tests, slimming down dockerfile Mar 10, 2023
@ialarmedalien ialarmedalien self-assigned this Mar 15, 2023
@ialarmedalien ialarmedalien requested a review from bio-boris March 15, 2023 17:43
Copy link
Contributor

@bio-boris bio-boris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ialarmedalien ialarmedalien merged commit 2501e08 into develop Mar 15, 2023
@ialarmedalien ialarmedalien deleted the fix_actions branch March 15, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants