Removing "-t" flag to allow github actions to run kb-sdk #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I had to workaround this on some Github actions stuff by editing the |
|
LGTM |
jsfillman
approved these changes
Oct 22, 2020
|
This eliminates the need for a custom |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Actions cannot run kb-sdk when it is in a docker container because the
entrypointscript adds the-tflag to the docker command (to add a TTY-type interface to the container), which causes GitHub Actions to error out. Since the commands that the entry point script is adding can't be run interactively, the-tflag can be safely removed.