Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVOPS-1037 Update Condor Base Image and DeDockerize #31

Draft
wants to merge 72 commits into
base: develop
Choose a base branch
from

Conversation

bio-boris
Copy link
Collaborator

No description provided.

@@ -1,41 +1,7 @@
FROM htcondor/cm:9.11-el7
FROM htcondor/cm:9.12.0-el7
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New base image, removing extra stuff from dockerfile

Based on the htcondor/cm:9.X images

## Supported ENV Variables
## New behavior
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh, looks like I forgot to update this with the variables from pre-exec.sh. Will have to do that next

@@ -0,0 +1,11 @@
#!/usr/bin/env bash
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this should be documented somewhere? This will need to be run on each environment we deploy

@@ -0,0 +1,5 @@
#!/usr/bin/env bash
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could delete this since its currently unused

rm /tmp/dockerize.tgz

#ADD DIRS
RUN mkdir -p /var/run/condor && mkdir -p /var/log/condor && mkdir -p /var/lock/condor && mkdir -p /var/lib/condor/execute
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Old line for creating dirs

fi

####################### HOST PATHS ############################################
DIRS_TO_CREATE=$(condor_config_val DIRS_TO_CREATE)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This adds the group to the condor user, and allows these files to be written by owner and group

@bio-boris bio-boris changed the title New base image DEVOPS-1037 Update Condor Base Image and DeDockerize Feb 17, 2023
Copy link
Contributor

@jsfillman jsfillman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally 🤘 !!

Let's shipit - :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants