Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add callback urls back in for NERSC file transfers #48

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Conversation

MrCreosote
Copy link
Member

Tested in the same way as prior URLs except pointed the callback urls at CI Groups and checked the service logs for requests

also DRYed up manifest generation a little

Tested in the same way as prior URLs except pointed the callback urls at
CI Groups and checked the service logs for requests

also DRYed up manifest generation a little
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 23.52941% with 13 lines in your changes missing coverage. Please review.

Project coverage is 80.07%. Comparing base (a053c87) to head (8e2eb03).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
cdmtaskservice/nersc/manager.py 12.50% 7 Missing ⚠️
cdmtaskservice/nersc/remote.py 33.33% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #48      +/-   ##
==========================================
- Coverage   81.21%   80.07%   -1.14%     
==========================================
  Files           9        9              
  Lines         527      537      +10     
==========================================
+ Hits          428      430       +2     
- Misses         99      107       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Tianhao-Gu Tianhao-Gu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MrCreosote MrCreosote merged commit abfa4da into main Sep 27, 2024
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants