Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add GHA test.yml, codeql, and dependabot.yml #136

Merged
merged 28 commits into from
Dec 17, 2024
Merged

Conversation

Xiangs18
Copy link
Collaborator

No description provided.

@Xiangs18 Xiangs18 changed the title add gha test.yml file [WIP] add gha test.yml file Mar 29, 2024
Copy link

codecov bot commented Dec 11, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@Xiangs18 Xiangs18 changed the title [WIP] add gha test.yml file add GHA test.yml, codeql, and dependabot.yml Dec 11, 2024
@Xiangs18 Xiangs18 requested a review from MrCreosote December 11, 2024 23:43
.github/codeql.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved

# setup kb-sdk
mkdir -p $(pwd)/bin
docker run kbase/kb-sdk genscript > $(pwd)/bin/kb-sdk
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the old sdk; I'm surprised it works here

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is similar to https://kbase.github.io/kb_sdk_docs/tutorial/2_install.html

For setting up, how is the new SDK different from the old one?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that tutorial probably won't work in a lot of scenarios

The SDK patch Dakota made upgrades the docker service

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there anywhere I can find the latest setup/install instructions for kb-sdk?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/kbase/kb_sdk_patch

If it works it works though

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I switched to the patch, and it seems to be working.

lib/biokbase/catalog/registrar.py Outdated Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the changes in this file from the module updates we did? I forget where they came from

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, it was switching from the prior commit to this one kbaseincubator/catalog_test_module@a8915af

.github/workflows/test.yml Outdated Show resolved Hide resolved
@Xiangs18
Copy link
Collaborator Author

Mongo7 upgrade PR next

@Xiangs18 Xiangs18 requested a review from MrCreosote December 16, 2024 22:08
.github/workflows/test.yml Show resolved Hide resolved
.github/workflows/test.yml Show resolved Hide resolved
Copy link
Member

@MrCreosote MrCreosote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Xiangs18 Xiangs18 merged commit dd630ce into develop Dec 17, 2024
7 checks passed
@Xiangs18 Xiangs18 deleted the dev-gha_script branch December 17, 2024 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants