Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

triple quotes memory leak -> fix #3

Merged
merged 14 commits into from
Nov 1, 2024
Merged

triple quotes memory leak -> fix #3

merged 14 commits into from
Nov 1, 2024

Conversation

srghma
Copy link
Collaborator

@srghma srghma commented Oct 23, 2024

No description provided.

@srghma
Copy link
Collaborator Author

srghma commented Oct 24, 2024

Now I have an error on 76d75b2

 ~/projects/tree-sitter-idris   main  npm run test

> tree-sitter-idris@0.0.1 test
> node --test bindings/node/*_test.cjs

✖ can load grammar (4.30676ms)
  AssertionError [ERR_ASSERTION]: Got unwanted exception.
  Actual message: "/home/srghma/projects/tree-sitter-idris/build/Release/tree_sitter_idris_binding.node: undefined symbol: tree_sitter_idris_external_scanner_create"
      at TestContext.<anonymous> (/home/srghma/projects/tree-sitter-idris/bindings/node/binding_test.cjs:8:10)
      at Test.runInAsyncScope (node:async_hooks:211:14)
      at Test.run (node:internal/test_runner/test:930:25)
      at Test.start (node:internal/test_runner/test:829:17)
      at startSubtestAfterBootstrap (node:internal/test_runner/harness:289:17) {
    generatedMessage: false,
    code: 'ERR_ASSERTION',
    actual: Error: /home/srghma/projects/tree-sitter-idris/build/Release/tree_sitter_idris_binding.node: undefined symbol: tree_sitter_idris_external_scanner_create
        at Module._extensions..node (node:internal/modules/cjs/loader:1717:18)
        at Module.load (node:internal/modules/cjs/loader:1317:32)
        at Module._load (node:internal/modules/cjs/loader:1127:12)
        at TracingChannel.traceSync (node:diagnostics_channel:315:14)
        at wrapModuleLoad (node:internal/modules/cjs/loader:217:24)
        at Module.require (node:internal/modules/cjs/loader:1339:12)
        at require (node:internal/modules/helpers:135:16)
        at load (/home/srghma/projects/tree-sitter-idris/node_modules/node-gyp-build/node-gyp-build.js:22:10)
        at Object.<anonymous> (/home/srghma/projects/tree-sitter-idris/bindings/node/index.cjs:3:43)
        at Module._compile (node:internal/modules/cjs/loader:1546:14),
    expected: undefined,
    operator: 'doesNotThrow'
  }

ℹ tests 1
ℹ suites 0
ℹ pass 0
ℹ fail 1
ℹ cancelled 0
ℹ skipped 0
ℹ todo 0
ℹ duration_ms 40.507796

✖ failing tests:

test at bindings/node/binding_test.cjs:6:1
✖ can load grammar (4.30676ms)
  AssertionError [ERR_ASSERTION]: Got unwanted exception.
  Actual message: "/home/srghma/projects/tree-sitter-idris/build/Release/tree_sitter_idris_binding.node: undefined symbol: tree_sitter_idris_external_scanner_create"
      at TestContext.<anonymous> (/home/srghma/projects/tree-sitter-idris/bindings/node/binding_test.cjs:8:10)
      at Test.runInAsyncScope (node:async_hooks:211:14)
      at Test.run (node:internal/test_runner/test:930:25)
      at Test.start (node:internal/test_runner/test:829:17)
      at startSubtestAfterBootstrap (node:internal/test_runner/harness:289:17) {
    generatedMessage: false,
    code: 'ERR_ASSERTION',
    actual: Error: /home/srghma/projects/tree-sitter-idris/build/Release/tree_sitter_idris_binding.node: undefined symbol: tree_sitter_idris_external_scanner_create
        at Module._extensions..node (node:internal/modules/cjs/loader:1717:18)
        at Module.load (node:internal/modules/cjs/loader:1317:32)
        at Module._load (node:internal/modules/cjs/loader:1127:12)
        at TracingChannel.traceSync (node:diagnostics_channel:315:14)
        at wrapModuleLoad (node:internal/modules/cjs/loader:217:24)
        at Module.require (node:internal/modules/cjs/loader:1339:12)
        at require (node:internal/modules/helpers:135:16)
        at load (/home/srghma/projects/tree-sitter-idris/node_modules/node-gyp-build/node-gyp-build.js:22:10)
        at Object.<anonymous> (/home/srghma/projects/tree-sitter-idris/bindings/node/index.cjs:3:43)
        at Module._compile (node:internal/modules/cjs/loader:1546:14),
    expected: undefined,
    operator: 'doesNotThrow'
  }

@srghma
Copy link
Collaborator Author

srghma commented Oct 26, 2024

@kayhide could You add me as maintainer?

@kayhide
Copy link
Owner

kayhide commented Nov 1, 2024

@srghma Hi, thank you for your PR. It looks good.

@kayhide kayhide merged commit fabf1b9 into kayhide:main Nov 1, 2024
3 checks passed
@kayhide
Copy link
Owner

kayhide commented Nov 1, 2024

@kayhide could You add me as maintainer?

Okay, I will add you as a maintainer.

@srghma
Copy link
Collaborator Author

srghma commented Nov 1, 2024

AWE-SOME!!!!))))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants